Remove node externals #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjspace In |
|
@ggetz I pinned the version of cesium to |
|
Looks good, thanks @jjspace! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of CesiumJS
v1.114which included CesiumGS/cesium#11773 the external node modules are no longer necessary and can be excluded from the config. This pr removes them.@ggetz Do you think it makes sense to still include a comment about this in the readme or somewhere? Or just remove and only support the latest version of cesium?
Testing
npm installnpm run devand check the local version worksnpm run buildand make sure there are no errorsnpm run previewand make sure the local built version still works